[JIRA] Created: (SIDP-549) Incorrect handling of returned authn error in SSO profile handlers

[marian.cvecka@idp.protectnetwork.org (JIRA)]

Incorrect handling of returned authn error in SSO profile handlers
------------------------------------------------------------------

                 Key: SIDP-549
                 URL: https://issues.shibboleth.net/jira/browse/SIDP-549
             Project: Shibboleth IdP 2 - Java
          Issue Type: Bug
          Components: SAML 2
    Affects Versions: 2.3.6
            Reporter: marian.cvecka at idp.protectnetwork.org
            Assignee: Chad La Joie


It appears that this issue https://issues.shibboleth.net/jira/browse/SIDP-427 has been reintroduced in the version 2.3.6. This time there is the following code in the processRequest method:

{code}
            if(!(loginContext instanceof Saml2LoginContext)){
                log.debug("Incoming request contained a login context but it was not a Saml2LoginContext, processing as first leg of request");
                performAuthentication(inTransport, outTransport);
                return;
            }
            
            if(!loginContext.isPrincipalAuthenticated()){
                log.debug("Incoming request contains a login context but principal was not authenticated, processing first leg of request");
                performAuthentication(inTransport, outTransport);
                return;
            }
            
            if(loginContext.isPrincipalAuthenticated()){
                log.debug("Incoming request contains a login context and indicates principal was authenticated, processing second leg of request");
                completeAuthenticationRequest((Saml2LoginContext)loginContext, inTransport, outTransport);
                return;
            }
            
            if(loginContext.getAuthenticationFailure() != null){
                log.debug("Incoming request contains a login context and indicates there was an error authenticating the principal, processing second leg of request");
                completeAuthenticationRequest((Saml2LoginContext)loginContext, inTransport, outTransport);
                return;
            }
{code}

The code execution has no chance to reach the last if statement.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira