[java-identity-provider] branch master updated: Improve warning messages.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=6cc43cc7de0a018ee9589a16b4df81aa6e98009f

The following commit(s) were added to refs/heads/master by this push:
       new  6cc43cc   Improve warning messages.
6cc43cc is described below

commit 6cc43cc7de0a018ee9589a16b4df81aa6e98009f
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Fri Apr 24 10:50:29 2020 -0400

    Improve warning messages.
---
 .../main/java/net/shibboleth/idp/saml/metadata/ACSUIInfo.java    | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/idp-saml-api/src/main/java/net/shibboleth/idp/saml/metadata/ACSUIInfo.java b/idp-saml-api/src/main/java/net/shibboleth/idp/saml/metadata/ACSUIInfo.java
index d97d0c0..689958b 100644
--- a/idp-saml-api/src/main/java/net/shibboleth/idp/saml/metadata/ACSUIInfo.java
+++ b/idp-saml-api/src/main/java/net/shibboleth/idp/saml/metadata/ACSUIInfo.java
@@ -36,7 +36,7 @@ import net.shibboleth.utilities.java.support.annotation.constraint.Unmodifiable;
 public class ACSUIInfo {
     
     /** logger. */
-    private static final Logger LOG = LoggerFactory.getLogger(ACSUIInfo.class);
+    @Nonnull private static final Logger LOG = LoggerFactory.getLogger(ACSUIInfo.class);
     
     /** The Service Names as a map from locale to actual value.*/ 
     @Nonnull @Unmodifiable private final Map<Locale, String> serviceNames;
@@ -48,12 +48,13 @@ public class ACSUIInfo {
     private final Predicate<LocalizedName> nullLanguageString = new Predicate<>() {
         public boolean test(final LocalizedName u) {
             if (u.getXMLLang() == null) {
-                LOG.warn("String with value {} in <AttributeConsumingService/>" +
-               " has no language associated, ignoring", u.getValue());
+                LOG.warn("<{}> with value {} in <AttributeConsumingService>" +
+               " has no language associated, ignoring", u.getElementQName().getLocalPart(), u.getValue());
                 return false;
             } 
             if (u.getValue() == null) {
-                LOG.warn("Ignoring empty string in <AttributeConsumingService/>", u.getValue());
+                LOG.warn("Ignoring empty <{}> element in <AttributeConsumingService>",
+                        u.getElementQName().getLocalPart(), u.getValue());
                 return false;
             }
             return true;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.