[java-identity-provider] branch master updated: IDP-1593 Widen testing for null strings in ACSUiInfo.

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch master
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=2b48c22999b070cb65808098193015de9cc24fd0

The following commit(s) were added to refs/heads/master by this push:
       new  2b48c22   IDP-1593 Widen testing for null strings in ACSUiInfo.
2b48c22 is described below

commit 2b48c22999b070cb65808098193015de9cc24fd0
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Sat Apr 18 17:02:39 2020 +0100

    IDP-1593 Widen testing for null strings in ACSUiInfo.
    
    https://issues.shibboleth.net/jira/browse/IDP-1593
---
 .../src/main/java/net/shibboleth/idp/saml/metadata/ACSUIInfo.java  | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/idp-saml-api/src/main/java/net/shibboleth/idp/saml/metadata/ACSUIInfo.java b/idp-saml-api/src/main/java/net/shibboleth/idp/saml/metadata/ACSUIInfo.java
index d263ad4..35e3bdc 100644
--- a/idp-saml-api/src/main/java/net/shibboleth/idp/saml/metadata/ACSUIInfo.java
+++ b/idp-saml-api/src/main/java/net/shibboleth/idp/saml/metadata/ACSUIInfo.java
@@ -48,7 +48,12 @@ public class ACSUIInfo {
     private final Predicate<LocalizedName> nullLanguageString = new Predicate<>() {
         public boolean test(final LocalizedName u) {
             if (u.getXMLLang() == null) {
-                LOG.warn("String with value {} has no language associated, ignoring", u.getValue());
+                LOG.warn("String with value {} in AssertionConsumerService" +
+               " has no language associated, ignoring", u.getValue());
+                return false;
+            } 
+            if (u.getValue() == null) {
+                LOG.warn("Ignoring empty string in AssertionConsumerService", u.getValue());
                 return false;
             }
             return true;

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.