[java-support] branch master updated: JSPT-75 - SerializeSupport.prettyPrintXML test fails under Java 9

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository java-support.

View the commit online:
http://git.shibboleth.net/view/?p=java-support.git;a=commit;h=06c862b3e6a9650c3c5198bc9c00991896fad703

The following commit(s) were added to refs/heads/master by this push:
       new  06c862b   JSPT-75 - SerializeSupport.prettyPrintXML test fails under Java 9
06c862b is described below

commit 06c862b3e6a9650c3c5198bc9c00991896fad703
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Apr 7 14:09:33 2020 -0400

    JSPT-75 - SerializeSupport.prettyPrintXML test fails under Java 9
    
    https://issues.shibboleth.net/jira/browse/JSPT-75
    
    Finalize test under Java 11+ by just fixing test data.
---
 .../utilities/java/support/xml/SerializeSupportTest.java      | 11 ++---------
 .../utilities/java/support/xml/serializeSupportTest.xml       |  2 +-
 2 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/src/test/java/net/shibboleth/utilities/java/support/xml/SerializeSupportTest.java b/src/test/java/net/shibboleth/utilities/java/support/xml/SerializeSupportTest.java
index 39f4a3c..3362a49 100644
--- a/src/test/java/net/shibboleth/utilities/java/support/xml/SerializeSupportTest.java
+++ b/src/test/java/net/shibboleth/utilities/java/support/xml/SerializeSupportTest.java
@@ -42,7 +42,6 @@ import org.w3c.dom.ls.LSSerializer;
 import org.xml.sax.SAXException;
 
 import net.shibboleth.utilities.java.support.component.ComponentInitializationException;
-import net.shibboleth.utilities.java.support.testing.TestSupport;
 
 /**
  * Tests for {@link NamespaceSupport}
@@ -192,14 +191,8 @@ public class SerializeSupportTest {
 
         final Document dom = parserPool.parse(new StringReader(s));
 
-        // JSPT-75:  Versions < 9 (i.e. until 1.8) would pass this bogus test.
-        // TODO: working test for Java 9, or rework
-        if (TestSupport.isJavaV9OrLater()) {
-            // skip the test
-        } else {
-            Assert.assertTrue(SerializeSupport.nodeToString(dom.getFirstChild()).equals(SerializeSupport.nodeToString(parent)),
-                "Should serialize to same output");
-        }
+        Assert.assertTrue(SerializeSupport.nodeToString(dom.getFirstChild()).equals(SerializeSupport.nodeToString(parent)),
+            "Should serialize to same output");
 
         assertEquals(dom.getFirstChild(), parent);
 
diff --git a/src/test/resources/net/shibboleth/utilities/java/support/xml/serializeSupportTest.xml b/src/test/resources/net/shibboleth/utilities/java/support/xml/serializeSupportTest.xml
index a334212..9f43e1d 100644
--- a/src/test/resources/net/shibboleth/utilities/java/support/xml/serializeSupportTest.xml
+++ b/src/test/resources/net/shibboleth/utilities/java/support/xml/serializeSupportTest.xml
@@ -1,3 +1,3 @@
 <me:Parent xmlns:me="http://example.org/Outer" xmlns="http://example.org/Outer">
-  <Child/>
+    <Child/>
 </me:Parent>

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.