[java-opensaml] branch master updated: ImmutableList remediation.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch master
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=4c074cc37d37b344aa47546f667fb8e732866fef

The following commit(s) were added to refs/heads/master by this push:
       new  4c074cc   ImmutableList remediation.
4c074cc is described below

commit 4c074cc37d37b344aa47546f667fb8e732866fef
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon Apr 6 16:05:06 2020 -0400

    ImmutableList remediation.
---
 .../org/opensaml/saml/criterion/BindingCriterion.java    | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)

diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/BindingCriterion.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/BindingCriterion.java
index e5ef7f2..973375a 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/BindingCriterion.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/criterion/BindingCriterion.java
@@ -17,17 +17,13 @@
 
 package org.opensaml.saml.criterion;
 
-import java.util.ArrayList;
 import java.util.List;
 
 import javax.annotation.Nonnull;
 
-import com.google.common.collect.ImmutableList;
-
 import net.shibboleth.utilities.java.support.annotation.constraint.NonnullElements;
 import net.shibboleth.utilities.java.support.annotation.constraint.NotLive;
 import net.shibboleth.utilities.java.support.annotation.constraint.Unmodifiable;
-import net.shibboleth.utilities.java.support.logic.Constraint;
 import net.shibboleth.utilities.java.support.primitive.StringSupport;
 import net.shibboleth.utilities.java.support.resolver.Criterion;
 
@@ -43,15 +39,7 @@ public final class BindingCriterion implements Criterion {
      * @param bindingURIs list of SAML binding URIs
      */
     public BindingCriterion(@Nonnull @NonnullElements final List<String> bindingURIs) {
-        Constraint.isNotNull(bindingURIs, "Binding list cannot be null");
-        
-        bindings = new ArrayList<>(bindingURIs.size());
-        for (final String binding : bindingURIs) {
-            final String trimmed = StringSupport.trimOrNull(binding);
-            if (trimmed != null) {
-                bindings.add(trimmed);
-            }
-        }
+        bindings = List.copyOf(StringSupport.normalizeStringCollection(bindingURIs));
     }
 
     /**
@@ -60,7 +48,7 @@ public final class BindingCriterion implements Criterion {
      * @return the SAML binding URI
      */
     @Nonnull @NonnullElements @Unmodifiable @NotLive public List<String> getBindings() {
-        return ImmutableList.copyOf(bindings);
+        return bindings;
     }
 
     /** {@inheritDoc} */

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.