<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Verdana, Geneva, sans-serif; font-size: 10pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof ContentPasted0">
Hi there Scott, thank you for your reply!
<div><br class="ContentPasted0">
</div>
<div class="ContentPasted0">Our login.vm file contains `#parse("login-error.vm")` (just like the default I can see in login.vm.idpnew)</div>
<div class="ContentPasted0 elementToProof ContentPasted1">The file login-error.vm doesn't look like it has been modified by our front-end developers, tried replacing the old version with login-error.vm.idpnew, but the only difference that makes is that the
error is displayed cursive, but it didn't change the facts described in my last mail:</div>
<div class="ContentPasted0">* we only get the static error message defined in messages/messages.properties:authn.message</div>
<div class="ContentPasted0">* that error message is already displayed when the form is first displayed (probably because of the failed Function authFlow that runs first and tries to login via our custom SSO-cookie)</div>
<div><br class="ContentPasted0">
</div>
<div class="ContentPasted0">Do you have any hint's how I could get back the behaviour from 4.2.1 and before where we only get an error message after a failed password login attempt and that one is the custom one thrown from our JAAS code like: throw new FailedLoginException(ourErrorMessage)?</div>
<div><br class="ContentPasted0">
</div>
<div class="ContentPasted0">Thank you,</div>
<div class="ContentPasted0">kind regards,</div>
Thomas Käfer</div>
<div style="font-family: Verdana, Geneva, sans-serif; font-size: 10pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof ContentPasted0">
<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>Von:</b> Cantor, Scott <cantor.2@osu.edu><br>
<b>Gesendet:</b> Dienstag, 11. April 2023 14:49<br>
<b>An:</b> Shib Users <users@shibboleth.net><br>
<b>Cc:</b> Käfer Thomas <thomas.kaefer@fh-campuswien.ac.at><br>
<b>Betreff:</b> Re: IDP 4.3.1 login.vm view - error messages?</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Probably this bug fix to make error handling more consistent.<br>
<br>
<a href="https://shibboleth.atlassian.net/browse/IDP-2049">https://shibboleth.atlassian.net/browse/IDP-2049</a><br>
<br>
You need to review how your login error handling works (they're your templates, that happens immediately after install and enabling the Password module) and adjust anything you want to adjust. The defaults are examples for ways to process error events and display
them.<br>
<br>
See also [1].<br>
<br>
-- Scott<br>
<br>
[1] <a href="https://git.shibboleth.net/view/?p=java-identity-provider.git;a=commitdiff;h=8f46219e801622027c98b48dc93f1b32d25ff664">
https://git.shibboleth.net/view/?p=java-identity-provider.git;a=commitdiff;h=8f46219e801622027c98b48dc93f1b32d25ff664</a><br>
<br>
</div>
</span></font></div>
<div style="font-size:10pt; font-family: 'Verdana',sans-serif;">
<p>Informationen zum Datenschutz: www.fh-campuswien.ac.at/datenschutzerklaerung </p>
</div>
</body>
</html>