<div dir="auto"><div dir="auto">On the subject of logging of properties on startup, it's also worth noting that this could potentially log the values of secrets. The logging code does hide values if the property names match a hard-coded (and not documented?) pattern, but people with custom properties could fall foul of this.</div><div dir="auto"><br></div>Max<div dir="auto"><br><div class="gmail_quote" dir="auto"><div dir="ltr" class="gmail_attr">On Wed, 4 May 2022, 17:43 Duncan Brannen via users, <<a href="mailto:users@shibboleth.net" target="_blank" rel="noreferrer">users@shibboleth.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div dir="ltr">
<div></div>
<div>
<div dir="ltr">That's exactly it ( and ldap.properties ) the logging what was doing in the 4.2 installer was much appreciated.</div>
<div id="m_8989442829613179187m_1048605700910383580ms-outlook-mobile-signature">
<div><br>
</div>
Get <a href="https://aka.ms/o0ukef" rel="noreferrer noreferrer" target="_blank">Outlook for iOS</a></div>
<div id="m_8989442829613179187m_1048605700910383580mail-editor-reference-message-container">
<hr style="display:inline-block;width:98%">
<div id="m_8989442829613179187m_1048605700910383580divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif"><b>From:</b> users <<a href="mailto:users-bounces@shibboleth.net" rel="noreferrer noreferrer" target="_blank">users-bounces@shibboleth.net</a>> on behalf of Cantor, Scott via users <<a href="mailto:users@shibboleth.net" rel="noreferrer noreferrer" target="_blank">users@shibboleth.net</a>><br>
<b>Sent:</b> Wednesday, May 4, 2022 5:09 pm<br>
<b>To:</b> Shib Users <<a href="mailto:users@shibboleth.net" rel="noreferrer noreferrer" target="_blank">users@shibboleth.net</a>><br>
<b>Cc:</b> Cantor, Scott <<a href="mailto:cantor.2@osu.edu" rel="noreferrer noreferrer" target="_blank">cantor.2@osu.edu</a>><br>
<b>Subject:</b> Re: 4.2 upgrade issues
<div> </div>
</font></div>
<font size="2"><span style="font-size:11pt">
<div>Actually, I would guess the difference is that if your "backup" was also named idp.properties, the old code had a bug that was excluding it. It wasn't meant to, since a/idp.properties is definitely not assumed to be the same as b/idp.properties.<br>
<br>
So it was probably excluding it by accident of name, not because it was in a subdirectory.<br>
<br>
I'll add something about it to the ReleaseNotes but definitely not anything that's unintentional.<br>
<br>
-- Scott<br>
<br>
<br>
-- <br>
For Consortium Member technical support, see <a href="https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fshibboleth.atlassian.net%2Fwiki%2Fx%2FZYEpPw&data=05%7C01%7Cdbb%40st-andrews.ac.uk%7Cf91a241f0e1c4a3fe82408da2de86c59%7Cf85626cb0da849d3aa5864ef678ef01a%7C0%7C0%7C637872773520276811%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VY8MMuxh5fKB3Hm8G3uQD0EgdCzPdq8gXGDF9lxMiqY%3D&reserved=0" rel="noreferrer noreferrer" target="_blank">
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fshibboleth.atlassian.net%2Fwiki%2Fx%2FZYEpPw&data=05%7C01%7Cdbb%40st-andrews.ac.uk%7Cf91a241f0e1c4a3fe82408da2de86c59%7Cf85626cb0da849d3aa5864ef678ef01a%7C0%7C0%7C637872773520276811%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VY8MMuxh5fKB3Hm8G3uQD0EgdCzPdq8gXGDF9lxMiqY%3D&reserved=0</a><br>
To unsubscribe from this list send an email to <a href="mailto:users-unsubscribe@shibboleth.net" rel="noreferrer noreferrer" target="_blank">users-unsubscribe@shibboleth.net</a><br>
</div>
</span></font></div>
</div>
</div>
</div>
-- <br>
For Consortium Member technical support, see <a href="https://shibboleth.atlassian.net/wiki/x/ZYEpPw" rel="noreferrer noreferrer noreferrer" target="_blank">https://shibboleth.atlassian.net/wiki/x/ZYEpPw</a><br>
To unsubscribe from this list send an email to <a href="mailto:users-unsubscribe@shibboleth.net" rel="noreferrer noreferrer" target="_blank">users-unsubscribe@shibboleth.net</a><br>
</blockquote></div></div></div>