<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hello Nate,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks for the response, and taking a look at the source. If it works, your solution would be a good way to test whether removing Address will fix this SP.<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I'll also try submitting a feature request for supporting this long term.<br>
</div>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="Signature">
<div>
<div></div>
<div id="divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p style="margin-top:0px; margin-bottom:0px; margin-top:0; margin-bottom:0"><font size="2"><span style="font-size:12pt">Tony Plovich</span><span style="font-size:11pt"><br>
</span><span style="font-size:12pt">Business Information Systems</span><span style="font-size:11pt"><br>
</span><span style="font-size:12pt">Argonne National Laboratory</span><span style="font-size:11pt"></span></font><br>
</p>
</div>
</div>
</div>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> users <users-bounces@shibboleth.net> on behalf of Nate Klingenstein <ndk@signet.id><br>
<b>Sent:</b> Friday, February 5, 2021 6:14 PM<br>
<b>To:</b> Shib Users <users@shibboleth.net><br>
<b>Subject:</b> RE: Remove Address from SubjectConfirmationData</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Tony,<br>
<br>
Well, actually, if you just yank the HTTP Servlet Request property from that bean, you might end up with chaotic explosions, or you might end up with nothing populated. My Java stinks, so I can't tell you definitively, but if I were you, I would try that just
for fun.<br>
<br>
/system/flows/saml/saml2/sso-abstract-beans.xml:<br>
<br>
<bean id="AddSubjectConfirmationToSubjects"<br>
class="org.opensaml.saml.saml2.profile.impl.AddSubjectConfirmationToSubjects" scope="prototype"<br>
p:httpServletRequest-ref="shibboleth.HttpServletRequest"<br>
p:method="urn:oasis:names:tc:SAML:2.0:cm:bearer" /><br>
<br>
-><br>
<br>
<bean id="AddSubjectConfirmationToSubjects"<br>
class="org.opensaml.saml.saml2.profile.impl.AddSubjectConfirmationToSubjects" scope="prototype"<br>
p:method="urn:oasis:names:tc:SAML:2.0:cm:bearer" /><br>
<br>
<br>
Note that this would be a universal change, though, impacting all assertions coming out of the IdP. If it works.<br>
<br>
<br>
<a href="http://git.shibboleth.net/view/?p=java-opensaml.git;a=blob;f=opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/profile/impl/AddSubjectConfirmationToSubjects.java;h=3a8c721957b420c7b11f39da55a5ebf8a23ca4b4;hb=HEAD">http://git.shibboleth.net/view/?p=java-opensaml.git;a=blob;f=opensaml-saml-impl/src/main/java/org/opensaml/saml/saml2/profile/impl/AddSubjectConfirmationToSubjects.java;h=3a8c721957b420c7b11f39da55a5ebf8a23ca4b4;hb=HEAD</a><br>
<br>
121 // Default pulls from servlet request.<br>
122 addressLookupStrategy = new Function<>() {<br>
123 public String apply(final ProfileRequestContext input) {<br>
124 final String address = getHttpServletRequest() != null ?<br>
125 HttpServletSupport.getRemoteAddr(getHttpServletRequest()) : null;<br>
126 log.debug("{} Setting confirmation data Address to {}", getLogPrefix(),<br>
127 address != null ? address : "(none)");<br>
128 return address;<br>
129 }<br>
130 };<br>
<br>
289 SubjectConfirmationData confirmationData = null;<br>
290 <br>
291 final String address = addressLookupStrategy != null<br>
292 ? addressLookupStrategy.apply(profileRequestContext) : null;<br>
293 if (address != null) {<br>
294 confirmationData = confirmationData != null ? confirmationData : confirmationDataBuilder.buildObject();<br>
295 confirmationData.setAddress(address);<br>
296 }<br>
<br>
319 if (confirmationData != null) {<br>
320 confirmation.setSubjectConfirmationData(confirmationData);<br>
321 }<br>
<br>
<br>
Probably shouldn't be sending this,<br>
Nate.<br>
-- <br>
For Consortium Member technical support, see <a href="https://wiki.shibboleth.net/confluence/x/coFAAg">
https://wiki.shibboleth.net/confluence/x/coFAAg</a><br>
To unsubscribe from this list send an email to users-unsubscribe@shibboleth.net<br>
</div>
</span></font></div>
</body>
</html>