<div dir="ltr">No, the java NPE is not thrown for all requests. I'm trying to reproduce.<div>I can trigger both the tell-tale IdP DEBUG log message and the java NPE by pointing my browser to the login page:</div><div><a href="https://idp.alaska.edu/idp/Authn/MCB">https://idp.alaska.edu/idp/Authn/MCB</a></div><div>which of course happens frequently as people use browser navigation, presenting the IdP with a "request" from nowhere.</div><div><br></div><div>David</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 15, 2015 at 7:18 PM, David Langenberg <span dir="ltr"><<a href="mailto:davel@uchicago.edu" target="_blank">davel@uchicago.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Fascinating. What the MCB is doing at that particular line is trying to get the metadata for the RelyingParty. <div><br></div><div><a href="https://github.com/langedb/Shibboleth-Multi-Context-Broker/blob/issue-8/mcb-project/src/main/java/edu/internet2/middleware/assurance/mcb/authn/provider/MCBLoginServlet.java#L135" target="_blank">https://github.com/langedb/Shibboleth-Multi-Context-Broker/blob/issue-8/mcb-project/src/main/java/edu/internet2/middleware/assurance/mcb/authn/provider/MCBLoginServlet.java#L135</a><br></div><div><br></div><div>Does this get thrown for all SPs and all requests? I too see the NPEs in my logs, but since functionally everything seems to be working fine I don't feel it's a must-fix-immediately. As Michael said, you could wait and try 1.2.5 (1.2.4 has a pretty serious regression in it). I should note that as for Chicago, the next step for our shibboleth service is IdPv3 for which Unicon is building right now, so we don't plan on doing any more work on the current v2 code unless something very nasty is found.<div><br></div><div>Dave</div></div></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Wed, Apr 15, 2015 at 8:55 PM, Michael A Grady <span dir="ltr"><<a href="mailto:mgrady@unicon.net" target="_blank">mgrady@unicon.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Well, Hethmon fixed at least one NPE on 6/4/2014, which I wouldn't be surprised to find is *not* reflected in your current version:<div><br></div><div> <a href="https://github.com/Internet2/Shibboleth-Multi-Context-Broker/commit/4a1215a8262da007abf640e60de7cd2a0b81e888" target="_blank">https://github.com/Internet2/Shibboleth-Multi-Context-Broker/commit/4a1215a8262da007abf640e60de7cd2a0b81e888</a></div><div><br></div><div>Since we used a distribution that we actually got from David L., he might have a better idea on that. You probably want to update the MCB version you have. But I think there is still one outstanding issue he is working on, so you might still want to hold off and see if within the next few weeks he has a 1.2.5 (1.2.4 is the latest right now).</div><div><br><div><div>On Apr 15, 2015, at 3:48 PM, <a href="mailto:db@alaska.edu" target="_blank">db@alaska.edu</a> <<a href="mailto:dabantz@alaska.edu" target="_blank">dabantz@alaska.edu</a>> wrote:</div><br><blockquote type="cite"><div dir="auto"><div>Yes</div><div><br><br><a href="mailto:David.Bantz@me.com" target="_blank">David.Bantz@me.com</a><div>David.Bantz<span>@<a href="http://alaska.edu/" target="_blank">Alaska.edu</a></span><div><span><br></span></div></div></div><div><div><div><br>On Apr 15, 2015, at 12:41 PM, Michael A Grady <<a href="mailto:mgrady@unicon.net" target="_blank">mgrady@unicon.net</a>> wrote:<br><br></div><blockquote type="cite">What version of the MCB are you running at this point? Still the version we installed last year?<div><br><div><div>On Apr 15, 2015, at 3:00 PM, IAM David Bantz <<a href="mailto:dabantz@alaska.edu" target="_blank">dabantz@alaska.edu</a>> wrote:</div><br><blockquote type="cite"><div dir="ltr">Unnoticed till now but the localhost logs in /var/log/tomcat are rife with java null pointer exceptions thrown by the MCB, like that quoted below.<div><br></div><div>It doesn't seem to be damaging performance, but also seems worth knowing why. The IdP process log has a few lines at the same moment as the exception:</div><div><br></div><div>IdP Process log:</div><div><p><span>0</span><span>7:52:59</span><span>.787 - DEBUG [edu.internet2.middleware.assurance.mcb.authn.provider.MCBLoginServlet:114] - Request received from [172.30.247.112]</span></p><p><span>0</span><span>7:52:59</span><span>.787 - DEBUG [edu.internet2.middleware.assurance.mcb.authn.provider.MCBLoginServlet:126] - Creating new principal object for request.</span></p><div>
<br></div><p><span>0</span><span>7:52:59</span><span>.788 - DEBUG [edu.internet2.middleware.assurance.mcb.authn.provider.MCBLoginServlet:130] - principal = [{MCBUsernamePrincipal}[principal]]</span></p><p><span>--------</span></p></div><div><div>tomcat local host log:</div><div><p><span>Apr 15, 2015 7:52:59 AM org.apache.catalina.core.StandardWrapperValve invoke</span></p><p><span>SEVERE: Servlet.service() for servlet MCBLoginServlet threw exception</span></p><p><span>java.lang.NullPointerException</span></p><p><span> at edu.internet2.middleware.assurance.mcb.authn.provider.MCBLoginServlet.service(MCBLoginServlet.java:135)</span></p><p><span> at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)</span></p><p><span> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)</span></p><p><span> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)</span></p><p><span> at edu.internet2.middleware.shibboleth.idp.util.NoCacheFilter.doFilter(NoCacheFilter.java:50)</span></p><p><span> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)</span></p><p><span> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)</span></p><p><span> at edu.internet2.middleware.shibboleth.idp.session.IdPSessionFilter.doFilter(IdPSessionFilter.java:87)</span></p><p><span> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)</span></p><p><span> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)</span></p><p><span> at edu.internet2.middleware.shibboleth.common.log.SLF4JMDCCleanupFilter.doFilter(SLF4JMDCCleanupFilter.java:52)</span></p><p><span> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)</span></p><p><span> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)</span></p><p><span> at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:219)</span></p><p><span> at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)</span></p><p><span> at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)</span></p><p><span> at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)</span></p><p><span> at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:554)</span></p><p><span> at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)</span></p><p><span> at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)</span></p><p><span> at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:859)</span></p><p><span> at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:588)</span></p><p><span> at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489)</span></p><p><span> at java.lang.Thread.run(Thread.java:662)</span></p></div></div></div>
</blockquote></div><br><div>
<span style="border-collapse:separate;font-family:Helvetica;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;border-spacing:0px"><span style="border-collapse:separate;font-family:Helvetica;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;border-spacing:0px"><div style="word-wrap:break-word"><span style="border-collapse:separate;font-family:Helvetica;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;border-spacing:0px"><div style="word-wrap:break-word"><br>--<br>Michael A. Grady<br>Senior IAM Consultant, Unicon, Inc.</div></span></div></span></span>
</div>
<br></div></blockquote></div></div></div></blockquote></div><div><div><br><div>
<span style="border-collapse:separate;color:rgb(0,0,0);font-family:Helvetica;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="border-collapse:separate;color:rgb(0,0,0);font-family:Helvetica;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div style="word-wrap:break-word"><span style="border-collapse:separate;color:rgb(0,0,0);font-family:Helvetica;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div style="word-wrap:break-word"><br>--<br>Michael A. Grady<br>Senior IAM Consultant, Unicon, Inc.</div></span></div></span></span>
</div>
<br></div></div></div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div><div dir="ltr"><div>David Langenberg<div>Identity & Access Management Architect</div><div>The University of Chicago</div></div></div></div>
</font></span></div>
</blockquote></div><br></div>