<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">On 3/13/15 8:37 AM, Rod Widdowson
wrote:<br>
</div>
<blockquote
cite="mid:013701d05d8a$73bd9a20$5b38ce60$@steadingsoftware.com"
type="cite">
<blockquote type="cite">
<pre wrap="">On 13 Mar 2015, at 11:48, Dave Perry <a class="moz-txt-link-rfc2396E" href="mailto:Dave.Perry@hull-college.ac.uk"><Dave.Perry@hull-college.ac.uk></a>
</pre>
</blockquote>
<pre wrap="">wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
<MetadataFilter xsi:type="RequiredValidUntil"
xmlns="urn:mace:shibboleth:2.0:metadata"
maxValidityInterval="604800" />
That maxValidityInterval value will be interpreted as a number of
</pre>
</blockquote>
<pre wrap="">milliseconds
</pre>
<blockquote type="cite">
<pre wrap="">(about 10 minutes). UK federation metadata has a much longer validity
interval, hence the error.
</pre>
</blockquote>
<pre wrap="">
And to follow up the V2 documentation is wrong (and no one has noticed
before). I just checked the V2 sources (after I'd giveN myself CPr) and it
too expects ISO format (with integral numbers of ms as the fallback).</pre>
</blockquote>
<br>
<br>
If I'm not mistaken, this is actually a bug in v3. The v2 parser
used the filter's constructor to handle this (there was no property
setter), and that expects seconds, not ms. The v2 docs [1] are
consistent with that (and with the SP which also takes seconds for
this functionality).<br>
<br>
The v3 parser uses a new setMaxValidityInterval(long) filter method
that was added, and it expects ms. The ctor which converted seconds
to ms is not used.<br>
<br>
So both handle the duration format correctly, but there is a
change/regression in v3 in that a numeric value is treated as ms.
So a legacy config like 604800 (seconds) is going to break, treated
as 604800 ms. <br>
<br>
Pretty sure this is right, but Rod please check me on this. If so,
I guess we need to open a bug. (And I guess we can no longer laugh
at the NASA engineers who crashed the Mars probe due to a units
mistake).<br>
<br>
<br>
[1]
<a class="moz-txt-link-freetext" href="https://wiki.shibboleth.net/confluence/display/SHIB2/IdPMetadataProviderExamples">https://wiki.shibboleth.net/confluence/display/SHIB2/IdPMetadataProviderExamples</a><br>
</body>
</html>