Problems installing shibboleth-sp on localized versions of Windows

[von Wittich, Christoph]

Hi!

I am trying to install shibboleth-sp-3.4.1.4-win64.msi on Windows (german version) and it fails with "An error occurred while applying security settings. USERS is not a valid user or group."

The problem is that WiX will use lstrcmpW to compare the well known usernames which is case sensitve:
See https://github.com/wixtoolset/wix/blob/976ac446dcb4aa1bfcbf38e188deb1c3741a2e46/src/ext/Util/ca/secureobj.cpp#L643


The following two files should be changed:

https://git.shibboleth.net/view/?p=cpp-sp.git;a=blob;f=msi/WiX/ShibbolethSP-noarch.wxs;hb=e60077613fe2e3ace80d2264c0b675ef2081f94b

 <CreateFolder>
  32<https://git.shibboleth.net/view/?p=cpp-sp.git;a=blob;f=msi/WiX/ShibbolethSP-noarch.wxs;hb=e60077613fe2e3ace80d2264c0b675ef2081f94b#l32>           <Permission User="Administrators" GenericAll="yes" />
  33<https://git.shibboleth.net/view/?p=cpp-sp.git;a=blob;f=msi/WiX/ShibbolethSP-noarch.wxs;hb=e60077613fe2e3ace80d2264c0b675ef2081f94b#l33>           <Permission User="SYSTEM" GenericAll="yes" />
  34<https://git.shibboleth.net/view/?p=cpp-sp.git;a=blob;f=msi/WiX/ShibbolethSP-noarch.wxs;hb=e60077613fe2e3ace80d2264c0b675ef2081f94b#l34>           <Permission User="USERS" ReadPermission="yes" GenericRead="yes" GenericExecute="yes" Read="yes" />
  35<https://git.shibboleth.net/view/?p=cpp-sp.git;a=blob;f=msi/WiX/ShibbolethSP-noarch.wxs;hb=e60077613fe2e3ace80d2264c0b675ef2081f94b#l35>           <Permission User="[WEBSERVER_USER]" ReadPermission="yes" GenericRead="yes" GenericExecute="yes" Read="yes" />
  36<https://git.shibboleth.net/view/?p=cpp-sp.git;a=blob;f=msi/WiX/ShibbolethSP-noarch.wxs;hb=e60077613fe2e3ace80d2264c0b675ef2081f94b#l36>         </CreateFolder>


Should be:

  33<https://git.shibboleth.net/view/?p=cpp-sp.git;a=blob;f=msi/WiX/ShibbolethSP-noarch.wxs;hb=e60077613fe2e3ace80d2264c0b675ef2081f94b#l33>           <Permission User="LocalSystem" GenericAll="yes" />
  34<https://git.shibboleth.net/view/?p=cpp-sp.git;a=blob;f=msi/WiX/ShibbolethSP-noarch.wxs;hb=e60077613fe2e3ace80d2264c0b675ef2081f94b#l34>           <Permission User="Users" ReadPermission="yes" GenericRead="yes" GenericExecute="yes" Read="yes" />

And
https://git.shibboleth.net/view/?p=cpp-sp.git;a=blob;f=msi/WiX/ShibbolethSP-properties.wxi;hb=e60077613fe2e3ace80d2264c0b675ef2081f94b

39<https://git.shibboleth.net/view/?p=cpp-sp.git;a=blob;f=msi/WiX/ShibbolethSP-properties.wxi;hb=e60077613fe2e3ace80d2264c0b675ef2081f94b#l39>   <Property Id="WEBSERVER_USER" Value="USERS"  Secure="yes" />

Should be:

39<https://git.shibboleth.net/view/?p=cpp-sp.git;a=blob;f=msi/WiX/ShibbolethSP-properties.wxi;hb=e60077613fe2e3ace80d2264c0b675ef2081f94b#l39>   <Property Id="WEBSERVER_USER" Value="Users"  Secure="yes" />




Christoph von Wittich


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/users/attachments/20240314/99d7456a/attachment.htm>