shibboleth.Conditions.Scripted and User-Agent http header ?

[Jarno Huuskonen]

Hi,

With IdP-5.1.2 this shibboleth.Conditions.Scripted:
    <bean id="UEF.SameSiteCondition" parent="shibboleth.Conditions.Scripted"
factory-method="resourceScript"
        p:returnOnError="true" p:hideExceptions="true"
        c:_0="javascript" c:_1="%{idp.home}/conf/samesite.js" />
fails with:
ERROR [net.shibboleth.shared.logic.ScriptedPredicate:114] - Scripted
Predicate from file [/opt/shibboleth-idp/views/samesite.js]: Input of type
class org.apache.catalina.connector.RequestFacade was not of type class
org.opensaml.profile.context.ProfileRequestContext

It appears to work if I change the bean
parent="shibboleth.Conditions.Scripted"
to class="net.shibboleth.shared.logic.ScriptedPredicate"

Is this change expected ? (conditions.xml from idp-conf-impl-5.1.2.jar seems
to define:
    <bean id="shibboleth.Conditions.Scripted"
        class="net.shibboleth.profile.context.logic.ScriptedPredicate"
abstract="true" />
) (different class: net.shibboleth.profile.context.logic.ScriptedPredicate
vs. net.shibboleth.shared.logic.ScriptedPredicate)

(Original full IdP4.x example in this thread:
https://shibboleth.net/pipermail/users/2022-March/051910.html)

-Jarno

-- 
Jarno Huuskonen