Exception during in-place 4.2.1 to 4.3.1 upgrade

[Rod Widdowson]

> The intent was that it only runs on an initial install though, which can assume the usual properties. The bug might be in whatever
> caused it to run but I seem to recall I reported that and we fixed it.

In V4 it runs if it cannot file %{idp.home}\metadata\idp-metadata.xml, so that's another workaround - just create an empty file
there.

As Scott says its fixed and we only generate on clean installs (and even then only if the old file doesn't exist)

Rod