mdui:DisplayName minimum

Peter Schober peter.schober at univie.ac.at
Wed Apr 28 14:18:04 UTC 2021


* Cantor, Scott <cantor.2 at osu.edu> [2021-04-28 15:35]:
> The logic in the example template, which is of course immediately
> your code the instant you deploy the IdP (it's an example, never
> touched again by an upgrade), is guarding against the entityID
> *containing* the display name outright anywhere in the string to try
> and protect against displaying an entityID on the page in the case
> where there is no DisplayName in the metadata, causing the lookup to
> fall back to entityID.

Shouldn't the comparison be equal strings (not string A contained in
string B), i.e., only /not/ show the value if it's only/equal to the
entityID itself?

I'm surprised that didn't trip up many more deployers as the short
name of the service being part of the DNS name the entityID is also
based on is not all that uncommon, IMO.

-peter


More information about the users mailing list