Upgrading IPRangePredicate and predicate logic to idp 4.0.0

[Cantor, Scott]

On 3/24/20, 2:02 PM, "users on behalf of Redman, Chad" <users-bounces at shibboleth.net on behalf of chad_redman at unc.edu> wrote:

> In idp 4.0.0, the consistentAddressCondition property in the shibboleth.SessionManager bean now uses a BiPredicate
> instead of a Predicate. 

I hadn't caught that change. I didn't remember the original condition was added pre-4.

> Is there a better way of configuring this so that there is no Predicate/BiPredicate mismatch?

There's no better or worse, just what is. It will take a dive into the Java classes and then figuring out the Spring wiring to adapt things.

I don't have the code in front of me but I think the BiPredicate was to allow the condition to examine both addresses. Not caring about one of them should in theory allow wiring to narrow the parameter set down to just one and back to Predicate, so some kind of wrapper there is probably enough to fix it.

It might be reasonable to allow both types on the property and solve it that way for a lot of common cases where only the client address matters, but that's a 4.1/5.0 fix obviously.

-- Scott