Possible bug with Shib IdP v4.0.0

[Mak, Steve]

Hi all, I might have found an issue but I'm not sure where to report it.

I have some sp metadata that has the following elements:

<AttributeConsumingService index="1">
  <ServiceName xml:lang="en"/>
</AttributeConsumingService>

And in v3.4.6 this loaded fine using LocalDynamic.

But in v4.0.0 this is causing an error when I run aacli tool, and error logs in idp-process.

Aacli output: { "error": "RuntimeException" }

Idp-process log: 

2020-04-17 23:30:44,719 - DEBUG [net.shibboleth.idp.saml.metadata.impl.ByReferenceMetadataFilterBridge:74] - Bridging to 0 ByReference filters in Spring context
2020-04-17 23:30:44,732 - ERROR [net.shibboleth.idp.profile:-2] - Uncaught runtime exception
java.lang.NullPointerException: null
	at java.base/java.util.Objects.requireNonNull(Objects.java:221)
2020-04-17 23:30:44,740 - WARN [org.opensaml.profile.action.impl.LogEvent:101] - A non-proceed event occurred while processing the request: RuntimeException


The problem goes away when I remove the line:
	<ServiceName xml:lang="en"/>


Are we just doing sp metadata poorly is should I report this as a regression?

Thanks,

Steven Mak | Application Developer
University of Pennsylvania - ISC IAM
3401 Walnut St, Philadelphia PA 19104
T: 215-573-7214