Scripted Attributes in Shib 3.4.0

[Rod Widdowson]

Unrelated to your problem but

>            var BasicAttribute = Java.type("edu.internet2.middleware.shibboleth.common.attribute.provider.BasicAttribute");
>            eduPersonAffiliation = new BasicAttribute("eduPersonAffiliation");

By the syntax I can see that you are running Nashorn (V8 of java and later).  With Nashhorn you do not need these lines.  The attribute will be defined for you already.  In 3.4.4 you'll get a deprecation warning telling you that.

/Rod