Preconfigured metrics in IdP 3.3.1

[Cantor, Scott]

On 7/4/17, 4:57 AM, "users on behalf of Etienne Dysli-Metref" <users-bounces at shibboleth.net on behalf of etienne.dysli-metref at switch.ch> wrote:

> I'm trying the new metrics system in version 3.3 and getting excited to
> measure everything. :) The default counters for [LDAP] authentication
> successes/failures are great! I've managed to dynamically create
> counters for every profile.

Thanks for playing with it, the lack of feedback so far means I don't have a strong amount of insight into where to take it.

> I've also noticed in the code that many (all?) Action beans have a
> DEFAULT_METRIC_NAME constant. Does that mean each has a counter or timer
> attached to it? Should it be enabled in some way? I've added `<logger
> name="metrics.net.shibboleth.idp" level="INFO"/>` to my logback.xml but
> didn't see anything new popping up at the metrics endpoint.

Certain objects in the system that have natural names to use and a natural start/stop concept have the ability to be referenced at runtime to trigger counters and timers. Did you read the section in the docs on Per-Profile Instrumentation?

You have to create a script to name the ones you want to turn on and tie them to the objects you want to measure. The hooks are built in, the actual metrics aren't. That way it's not hardcoded or taking up a lot of time if you don't use them. I figured eventually federations would standardize on some things or make suggestions about what examples to give people.

In practice, one of the major needs is something I already patched in myself as an audit field, I added a "start time" for each profile request now so the basic timings for a whole request can be obtained that way without using this feature.

-- Scott