Code Review: Mapping Directory Groups to eduPersonEntitlement

[Cantor, Scott]

On 4/10/17, 8:19 PM, "users on behalf of Brian Moon" <users-bounces at shibboleth.net on behalf of bmoon at scu.edu> wrote:

> I just wrote a script to map directory groups to eduPersonEntitlement strings.  Everything seems to be working fine with it,
> although I would appreciate a code review to make sure that I haven't done anything stupid with it, or to see if there are areas
> that could be better optimized.

Well, if you're asking, I don't see the point of using the hack of loading JSON to do the mapping given that it's not going to reloadable in isolation anyway. I'd probably stick the mappings into a local MySQL table so it would be dynamic, or if I was satisfied with doing it statically, I'd probably just declarare a map as a Spring bean and access it from the script, which would certainly be a bit faster.

-- Scott