Incorrect idp.pool.LDAP.validatePeriod property format

[Cantor, Scott]

On 11/25/15, 4:54 AM, "users on behalf of Robo Burned" <users-bounces at shibboleth.net on behalf of robo at list.ru> wrote:



>Default configuration has the following in ldap.properties
>idp.pool.LDAP.validatePeriod = 300
>Connection Pool documentation <https://wiki.shibboleth.net/confluence/display/IDP30/ConnectionPool> says it must be Duration and
>schema <http://shibboleth.net/schema/idp/shibboleth-attribute-resolver-dc.xsd> says it must be in ISO8601 format.

That property isn't used anywhere except for a native Spring file that configures an ldaptive bean that isn't the same as the custom objects that documentation is talking about.

Our use of durations makes configuring them much simpler and readable but the downside is that they don't work on classes that are not written by the project.

>When I use configuration of connection pool from
>LDAP connector example  <https://wiki.shibboleth.net/confluence/display/IDP30/LDAPConnector>like this:
> validateTimerPeriod="%{idp.pool.LDAP.validatePeriod}"
>I get an error (whole stacktrace attached) 
>Failed to instantiate [long]: Factory method 'buildDuration' threw exception; nested exception is java.lang.IllegalArgumentException: 300

I don't know if that's a bug or not, but I do know we don't provide anything that uses the property in that context.

-- Scott