Adding SHA1 signing override

[Jeffrey Eaton]

I have an SP which doesn’t understand SHA-256 signatures, so in my IDPv3.1.2 testing, I am trying to add an override for this SP to use SHA-1 signatures.

The wiki suggests adding this to relying-party.xml

<bean id="SHA1SecurityConfig" parent="shibboleth.DefaultSecurityConfiguration"
    p:signatureSigningConfiguration-ref="shibboleth.SigningConfiguration.SHA1" />

But that didn’t seem to work.  

After much trial and error I came up with this, which seems to do the right thing:

<bean id="SHA1SecurityConfig" parent="shibboleth.DefaultSecurityConfiguration">
    <property name="signatureSigningConfiguration">
        <bean parent="shibboleth.SigningConfiguration.SHA1" />
    </property>
</bean>

which seems like more or less the same thing, if a bit more long-winded.  Is there anything wrong with doing it this way? 

-jeaton