Minor config issues requiring system/ files modification

[Robert Führicht]

Hi,

I'm migrating from IdP 2.x to 3.1.1. During setup I ran across some problems, that forced me to
modify system/ config files. As I am not sure if this is either a bug or I overlooked something,
here's what I modified and why:

- If the Velocity templates contain non-ASCII characters like Umlauts, the output is garbled regardless
of HTML content type. Modifying system/conf/global-system.xml helped:

     <bean id="messageSource" class="org.springframework.context.support.ReloadableResourceBundleMessageSource"
+        p:defaultEncoding="UTF-8"
+        p:fallbackToSystemLocale="false"
             p:cacheSeconds="%{idp.message.cacheSeconds:300}"
             p:basenames-ref="%{idp.message.resources:shibboleth.MessageSourceResources}" />

- My attribute resolver config uses attribute descriptions. The attribute consent template page doesn't 
use them, I wanted to add them to mine as tooltips. The template contains (I added the 'title' attribute):

<td title="$encoder.encodeForHTMLAttribute($attributeDisplayDescriptionFunction.apply($attribute))">
$encoder.encodeForHTML($attributeDisplayNameFunction.apply($attribute))
</td>

$attributeDisplayDescriptionFunction isn't defined though, so I had to modify system/flows/intercept/attribute-release-flow.xml
to include this:

 <evaluate expression="new net.shibboleth.idp.consent.logic.AttributeDisplayNameFunction(flowRequestContext.getExternalContext().getNativeRequest(), FallbackLanguages)" result="viewScope.attributeDisplayNameFunction" />
+<evaluate expression="new net.shibboleth.idp.consent.logic.AttributeDisplayDescriptionFunction(flowRequestContext.getExternalContext().getNativeRequest(), FallbackLanguages)" result="viewScope.attributeDisplayDescriptionFunction" />

Kindest regards,
Robert