Small bug report for Shib IdP 2.3.5

[David Gersic]

In conf/attribute-resolver.xml using the LDAP connector, if the principalCredential has an "&" in it, like:

    <!-- LDAP Connector -->
    <resolver:DataConnector id="myLDAP" xsi:type="dc:LDAPDirectory"
        ldapURL="ldaps://1.1.1.1" 
        baseDN="ou=people,dc=niu,dc=edu" 
        principal="cn=idpproxy,ou=ServiceAccounts,dc=NIU,dc=EDU"
        principalCredential="Change&Me1">
        <dc:FilterTemplate>
            <![CDATA[
                (uid=$requestContext.principalName)
            ]]>
        </dc:FilterTemplate>
    </resolver:DataConnector>

the IdP fails to start with:

16:19:44.333 - ERROR [edu.internet2.middleware.shibboleth.common.config.BaseService:188] - Configuration was not loaded for shibboleth.AttributeResolver service, error creating components.  The root cause of this error was: org.xml.sax.SAXParseException: The entity name must immediately follow the '&' in the entity reference.

It's easy enough to work around this, by simply changing the configured password to something else without the "&" in it, but I'm not convinced that this shouldn't have worked.