<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 5/24/17 2:28 PM, Cantor, Scott
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:99343751-400F-43EB-864F-970B18D05193@osu.edu">
<pre wrap="">
</pre>
<pre wrap="">
(mentally I would not think of it as "not expiring" but "still returns data even if expired"),</pre>
</blockquote>
<br>
Yes, I was sloppy with my phrasing.<br>
<br>
<br>
<blockquote type="cite"
cite="mid:99343751-400F-43EB-864F-970B18D05193@osu.edu">
<pre wrap=""> but I'm not concerned about the weird conflation of two edge features, one of which is pretty much never on until the warning happens and then you turn it on to avoid things breaking.</pre>
</blockquote>
<blockquote type="cite"
cite="mid:99343751-400F-43EB-864F-970B18D05193@osu.edu">
</blockquote>
<br>
By way of explanation, the reason I did it that way was: The
"already expired" check is actually not really that (as you sort of
say), it's "is it currently valid per isValid(XMLObject)".
isValid() is the (only) thing that evals requireValidMetadata. When
the latter is false, isValid() just trivially returns true,
otherwise it does the actual validation (which right now is just
validUntil checks, although a subclass could override). So
isValid() is what is actually going to discard (or not) candidate
metadata which is expired (or otherwise deemed invalid) during
resolution requests, so it made sense to me to use that for the root
expiration check for the new logging, to keep the logic in sync.<br>
<br>
And then in order to make the other 2 new logging cases consistent
with that, I also conditionalized them based on
requireValidMetadata, since it's going to be the same isValid()
logic that is relevant to whether the metadata is actually going to
expire in the future.<br>
</body>
</html>