<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">On 10/31/15 6:12 PM, Cantor, Scott
wrote:<br>
</div>
<blockquote cite="mid:F2FF1F03-E226-4768-92FC-507A1D9E6B6C@osu.edu"
type="cite">
<pre wrap="">
I realized there's really only one correct approach, we should just use Predicate<MessageContext> whereever that's appropriate, and then if we need a Predicate<ProfileRequestContext> we should build that adapter (and have it specify INBOUND or OUTBOUND).</pre>
</blockquote>
<br>
I agree, that's true in general.<br>
<br>
<br>
<blockquote cite="mid:F2FF1F03-E226-4768-92FC-507A1D9E6B6C@osu.edu"
type="cite">
<pre wrap=""> Otherwise we'd have to build the inbound/outbound flag into every one of these predicates anyway.</pre>
</blockquote>
<br>
For this specific predicate and use case, I assumed we'd only ever
care about it on the outbound side, since that's where we do
signing, so we *could* code a Predicate<PRC> that way. But
having a more general Predicate<MessageContext> is also fine.<br>
<br>
Given the latter, I guess we could in theory now make inbound
(slightly) more efficient by not even running the Redirect and POST
SimpleSign signature validating handlers if the binding doesn't
support signing.<br>
<br>
Or, even better, since those actually are binding-specific, have
them only run for those individual bindings rather than for
everything. They of course sanity check whether there's a raw
signature present, but we could now in theory short-circuit that.
We'd either need a binding URI predicate, or perhaps a more general
expression language one. Not urgent, maybe I'll put in an issue for
a future release. More an issue of testing than coding...<br>
<br>
</body>
</html>