<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 1/28/15 3:05 PM, Marvin Addison
wrote:<br>
</div>
<blockquote
cite="mid:CACOs9MSxPP6hUH185eFybcjqc117zG=U0DmQeQAcVpFUxkpopw@mail.gmail.com"
type="cite">
<div class="gmail_quote"><br>
<div><span style="font-size:13.1999998092651px"><br>
</span></div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<logger name="PROTOCOL_MESSAGE" level="DEBUG" /><br>
</blockquote>
<div><br>
</div>
<div>FWIW, I use this logger _frequently_ to diagnose interop
problems,<br>
</div>
</div>
</blockquote>
<br>
I don't think we can really change this one in any case. It's what
we've had and documented since the early days of v2, so that one
probably has to stay as-is IMHO. <br>
<br>
Related: do we keep the existing logback.xml on a v2 -> v3
upgrade? If we do, then we really can't change PROTOCOL_MESSAGE
period, it's locked in I think.<br>
<br>
In case it's not obvious, the reason we had and still have that one
is that logging to that comes out of multiple classes - many
different Decoders and Encoders. So it makes sense to have a
conceptual category. (Also easier to send to a separate file, it's
a lot of output.)<br>
<br>
If you have just one class that's going to log to a category, then
there's no reason to do a category other than allowing the
possibility of changing the class name (the -api vs -impl issue).
That's why I was leaning to getting rid of SAML_PRE_ENCRYPTION,
feels like an unnecessary complication.<br>
<br>
Really, this is all about: are logging categories part of an "API"
of sorts? Not really API, but in the sense of deployers and config
files.<br>
</body>
</html>