idp-war-3.4.4.war in Maven Repo is bad

[Ian Young]

> On 13 Jun 2019, at 00:44, Dan McLaughlin <dmclaughlin at tech-consortium.com> wrote:
> 
> The missing jar's
> really are runtime dependencies for the idp-war to function if you
> want to use the new UnboundIDProvider in 3.4.4  and they should be
> defined as such in the idp-war pom.


I think what you may be missing -- for the question of the logging dependencies in particular -- is that logback is not the only possible logging back-end. The intention of the way we have the dependencies set up is to allow the possibility of other logging back-ends to be used instead, in contexts where that's appropriate. So we're introducing logback into the product as late as possible in the process.

I'm not saying that this intention is 100% realised in our current setup: in fact, there's an outstanding JIRA case pointing out some irregularities in the way things are arranged. Also, your proposed patch includes some other dependency issues that may be worth looking at independently. But the right action is not as simple as just adding everything to idp-war's POM.

    -- Ian



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/dev/attachments/20190613/0255d1c1/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3870 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/dev/attachments/20190613/0255d1c1/attachment.p7s>