idp-war-3.4.4.war in Maven Repo is bad

[Cantor, Scott]

On 8/23/19, 4:35 AM, "dev on behalf of Etienne Dysli Metref" <dev-bounces at shibboleth.net on behalf of etienne.dysli-metref at switch.ch> wrote:

> Coming back to this (in IDP-1481), I find it a rather weak argument. Do
> you know of anyone going through the trouble of unpacking the
> distributed idp.war to remove Logback because they prefer to use another
> SLF4J implementation?

logback isn't the only example of "missing" jars, but you wouldn't have to remove them necessarily, but that's also an indictment of the fact that we don't currently support the removal of jars in the overall install process.
 
> That's a commendable intention, but the resulting WAR file isn't
> reusable by Maven, thereby thwarting other people's effort at automation.

The automation is already a problem if you're not running the installer because of upgrades, as I noted. You commented " Indeed configuration isn't taken into account here, it's left for the deployer to manage separately (not unfamiliar to those using Docker)."

But there's no way for a deployer to manage the configuration in that case since the installer is bult to manage the war, not just the configuration files.

What we have is just not designed to work with these sorts of deployment strategies and since none of us using the IdP for real understand them well, we're terribly positioned to support them at this point. But my thought was that we could compromise by adding some kind of additional overlay artifact that could be a bridge between what we need now and what people are trying to do with it.

-- Scott