Memory leak in SP 3.0.2?

[Cantor, Scott]

> Yes, for yesterday there are 16'900 lines in the SP's log like:

16,900!

That fits though, I hadn't really thought about it but queries over 443 are going to cause the SP to try and encrypt but most IdPs (rightly) are not going to publish an encryption key so that's going to be the norm. And these aren't going to be transient IDs either.

> and 2'789 lines like:
> 
> 2018-10-12 08:08:13.998 ERROR XMLTooling.SOAPTransport.CURL [2736]
> [default]: supplied TrustEngine failed to validate SSL/TLS server certificate

That wouldn't be fatal if the response is signed but perhaps those are misconfigured systems. I should probably review that case a bit and make sure the logging is appropriate. Lowering it to WARN at least is probably better.

> Yes, we have configured a MetadataExtractor like this:

Ah, good. That certainly fits then. It seemed like a noticeable leak would probably depend on pulling a decent number of attributes from the metadata.

Safe to say this is the leak I found. I checked in the fix last night.

-- Scott