XMLConfigurator.createClassInstance() should catch Throwable ?

[Tom Zeller]

TL;DR I think that
org.opensaml.core.xml.config.XMLConfigurator.createClassInstance()
should catch/handle Throwable in addition to Exception.

The tests for IdP 3.3.x were failing because I inadvertently had mixed
versions of OpenSAML on the test (Maven Surefire) classpath,
opensaml-api-* was 3.3.1 but opensaml-impl-* was 3.4.0-SNAPSHOT. It
was IDP-1217 that exposed the version mixmatch.

The tests were failing with :

java.lang.NoClassDefFoundError:
org/opensaml/saml/ext/reqattr/RequestedAttributes
Caused by: java.lang.ClassNotFoundException:
org.opensaml.saml.ext.reqattr.RequestedAttributes

when calling InitializationService.initialize();

Catching Throwable won't fix anything, but it should lead to a clearer
error message, I would think.

Tom