jetty-base 9.4 : download JARs or not ?

[Cantor, Scott]

On 5/31/17, 12:51 AM, "dev on behalf of Tom Zeller" <dev-bounces at shibboleth.net on behalf of tzeller at dragonacea.biz> wrote:

> The idea above is to use the JAR from the local Maven repo if not
> present in lib/. But, if the JAR does not exist in the local Maven
> repo, it is downloaded using java.net.HttpURLConnection from a
> hardcoded Maven Central URL, whereas we would want to use our Nexus
> repo.

I don't know if we care about the ones built-in to Jetty. If we were shipping the container and managing it, we'd probably ship all the jars to start with and control the whole fileset. If not, I don't see this as anything but an example, and if the example is documented to do what Jetty does by default and downloads from Maven central, so be it.

For our own jars we'd have to use a proper URL I guess but I don't know if it's worth overriding their modules if we don't have to.

> work. We could override the [files] section of the handful of Jetty's
> logging modules (by copying those modules to jetty-base/modules). We
> need to override versions anyways.

Why? There shouldn't be contamination between Jetty's classpath and the webapp(s), should there?

> If we really want to use Jetty to download files from our Nexus repo,
> it probably wouldn't be much work to submit a patch to use an env var
> if present instead of the hardcoded Maven Central URL.

I'm sure they'd probably accept that.

Really it's not so much the jars I'm curious about but the actual modules and files. If those are things we can host and point people to with a start.jar command to pull them in, that might eliminate us distributing any of this work. That was what I was really thinking of.

-- Scott