Items for Friday

Cantor, Scott cantor.2 at osu.edu
Tue Jan 31 10:19:20 EST 2017


> If we centralize the defaults (say in a class with each client deriving from it)
> we now have the have the knowledge in two places.

Well, I was saying if *we* have defaults in the IdP we're putting into the parsers, we'd just put those constants into a class. If some of those constants happen to match existing constants in the builders or components, because we had some reason for repeating the default, we could just do:

public static final int DEFAULT THING_TIMEOUT = net.shibboleth.java.support.net.thing.ThingBuilder.DEFAULT_THING_TMEOUT;

> Best idea I can come up with is to have the class with the defaults injected
> into the builder as well:

I was suggesting we just use named constants to help document the defaults, not anything fancy.
 
-- Scott



More information about the dev mailing list