Items for Friday

Cantor, Scott cantor.2 at osu.edu
Mon Jan 30 19:57:38 EST 2017


On 1/30/17, 7:50 PM, "dev on behalf of Brent Putman" <dev-bounces at shibboleth.net on behalf of putmanb at georgetown.edu> wrote:

>    True, but: as I mentioned in one of the (way too many) linked issues on this, HttpClient doesn't have any hard wall clock
> type of timeout over the whole request operation.

You did, I forgot that. Libcurl does have a total request timeout it enforces, just habit.

> Specifically it's relying on our HttpClientBuilder default.  If's fine with me to handle both explicitly for symmetry and style,
> but as I mention in IDP-1115 it would be advisable to not repeat the actual default values for batch from the HCB if we can
> avoid it.

I was thinking maybe we should just declare a public IdP class to hold any static Spring defaults (and we could make a public constant from the builder and assign it into the IdP field).

-- Scott




More information about the dev mailing list