StorageBackedSessionManager Contract

[Marvin Addison]

In testing the fix for IDP-996, I'm getting the following unexpected error
calling StorageBackedSessionManger#resolveSingle():

2016-09-20 06:56:10,429 - ERROR [net.shibboleth.idp.cas:?] - Uncaught
runtime exception
net.shibboleth.utilities.java.support.logic.ConstraintViolationException:
Storage object was not present in session
        at
net.shibboleth.utilities.java.support.logic.Constraint.isNotNull(Constraint.java:227)
        at
org.opensaml.storage.impl.client.ClientStorageService.getContextMap(ClientStorageService.java:304)
        at
org.opensaml.storage.AbstractMapBackedStorageService.readImpl(AbstractMapBackedStorageService.java:279)
        at
org.opensaml.storage.AbstractMapBackedStorageService.read(AbstractMapBackedStorageService.java:108)
        at
net.shibboleth.idp.session.impl.StorageBackedSessionManager.lookupBySessionId(StorageBackedSessionManager.java:795)

I would have expected it to simply return null in this case due to the
resolveSingle method bearning a @Nullable annotation on the return type.
Obviously I can trap this case as well, but it doesn't seem right to me.

M
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/dev/attachments/20160920/6663f1c2/attachment-0001.html>