R4481 Checkstyle Parameter Rename Issue
Rod Widdowson
rdw at steadingsoftware.com
Wed Sep 14 04:03:32 EDT 2016
> I wasn't aware of that capability, but I am in favor of a bit of work for us in the service of making the system easier to
configure.
Totally agree. I wasn't suggesting anything other than a "reminder in the code" when I suggest an annotation. The idea that it can
be used to drive this (and thus allow parameter name changes) is quite exciting. Of course at this stage the annotation becomes
part of the API, but it does hit you between the eyes - anyone can accidently change a parameter name when they brain is in neutral,
you have to actively think about removing annotations.
> should we bundle that work (if we so decide) when we move to Java 8 ?
I'm missing what the linkage is.
I thought we'd decided that Spring wasn't a driver (probably the only non-driver) for Java 8? I see that
DefaultParameterNameDiscoverer uses java 8 but also explicitly falls back. Java.lang.reflect.Constructor collected some new APIs in
8, but we don't need them.
Notwithstanding a need for Java 8, there may be room to add a @SpringParameterName(name="whatever") to appropriate classes? I think
that we decided that adding annotations is not an API change.
Something for Friday?
Rod
More information about the dev
mailing list