Freeze?

[Cantor, Scott]

> Having reviewed the Metrics docs again, I was planning on making some
> changes to what I initially checked in yesterday for the dynamic
> metadata resolver.  But didn't get to it by tonight.  I plan to do
> tomorrow afternoon at the latest.  I sort of think of that stuff as
> like logging, so it's not really core function, as you say.

That's fine. The only real issue I have is whether I want to somehow agglomerate the new metadata metrics into the original group I built up in the IdP or not.

What I did was build these objects that implement MetricSet and MetricFilter. The idea was to be able to register them all as unit with one Spring bean, and then also be able to access them with the API as a unit by labeling them (e.g. /idp/profile/admin/metrics/metadata). I just want to see if there's any way of integrating the new stuff in.

One point I guess, which relates to your question about counters specific to entityIDs: when I exposed (for example) the update time of the metadata resolvers, the way I decided to do it was just to make the Gauge for that a Map<String,DateTime> with the mapping from resolver ID to the value.

That way the access to the metric isn't specific to any one configuration of resolvers, but you can still access the specific one if you want to.

You might want to do something similar for the counters. You could have a Map<String,Long> and just expose the Map as the Gauge.

-- Scott