serializing custom principals

[Cantor, Scott]

> > In trunk it's in system/conf/general-authn-system.xml
> >
> 
> I do not see that in a deployed 3.2.1:

I was commenting on trunk.

> What am I missing?

3.2.1 didn't expose the collection, it's inline:

    <bean id="shibboleth.DefaultAuthenticationResultSerializer"
            class="net.shibboleth.idp.authn.impl.DefaultAuthenticationResultSerializer">
        <property name="principalSerializers">
            <list>
                <bean class="net.shibboleth.idp.authn.principal.impl.UsernamePrincipalSerializer" />
                <bean class="net.shibboleth.idp.authn.principal.impl.LDAPPrincipalSerializer" />
                <bean class="net.shibboleth.idp.authn.principal.impl.IdPAttributePrincipalSerializer" />
                <bean class="net.shibboleth.idp.authn.principal.impl.PasswordPrincipalSerializer"
                    p:dataSealer-ref="shibboleth.DataSealer" />
            </list>
        </property>

I pulled the property out so it can be merged into from outside. The only way to modify it in 3.2 is editing that file and adding to that list. The safe fix would be to copy the wiring changes I made for that bug fix so that the upgrade to 3.3 just puts the same changes over top.

That's generally workable for any of these kinds of changes, as long as the edit lines up with what gets released, the upgrade won't break it.

-- Scott