net.shibboleth.idp.attribute.resolver.spring.dc has changed in IDP 3.2.x

[Jim Fox]

I also noticed AbstractDataConnectorParser has become non public in 3.2

Jim


On Thu, 28 Jan 2016, Joey Wang wrote:

> Date: Thu, 28 Jan 2016 15:49:05
> From: Joey Wang <carbon_60 at yahoo.com>
> To: Shib Dev <dev at shibboleth.net>
> Reply-To: Shib Dev <dev at shibboleth.net>
> Subject: Re: net.shibboleth.idp.attribute.resolver.spring.dc has changed in
>     IDP 3.2.x
> 
> Thanks, Rod,
> 
> I am a little confused with your following statement:
> 
> Until 3.2 Spring modules were always considered as impl and therefore non public.  This was stupid and confusing and in 3.2 we changed it to the
> more simple "impl is non public".  This was actually motivated by precisely the class you reference
> (net.shibboleth.idp.attribute.resolver.spring.dc.AbstractDataConnectorParser) which has now become a public api, reflecting it's utility.
>  
> This statement seems said opposite to what it happened:
> 
> In 3.1.x and earlier, this class was in net.shibboleth.idp.attribute.resolver.spring.dc which implies (to me) it was public in 3.1.x
> 
> In 3.2.x, this class is in net.shibboleth.idp.attribute.resolver.spring.dc.impl which implies it is non-public in 3.2.x
> 
> Is my understand right?
> 
> Thanks, Joey
> 
> On Thursday, January 28, 2016 8:34 AM, Rod Widdowson <rdw at steadingsoftware.com> wrote:
> 
> 
> > .  Please update the document.
> 
> I’ll make a note, but it’s a wiki so anyone can edit it.  Please feel free to dive in.
> 
> > When I see impl as part of the name, I would assume that this is no longer a public API, is this change intentional?
> 
> When you see impl in a name is it not a public api.  But it is not “no longer” a public API, it never was. 
> 
> 
> But a whole bunch of other classes had their names changed to make their name coherent with their non public status.
> 
> Public Apis never disappear except in Major release.  But we are always open to arguments to make non public APIs public.
> 
> Thanks
> 
> 
> /Rod
> 
> 
> --
> To unsubscribe from this list send an email to dev-unsubscribe at shibboleth.net
> 
> 
>