Looking for help with Checkstyle and Shib v3

[Tom Zeller]

As mentioned on the 2016-01-15 dev call, we (the project) are interested in help with Checkstyle. The big-picture goal is clean code which follows our coding conventions[1].

Personally, I think that while housekeeping is a humble endeavor, it’s also a great way to get familiar with code.

Some tasks :

 IDP-865[2] Cleanup the CAS modules in IdPv3

 JPAR-60[3] Cleanup copyright headers

 JPAR-83[4] and JPAR-85[5] Use of the ‘final’ keyword

 JPAR-77[6] Fail builds if code is not clean

 Document how to configure Checkstyle in IntelliJ IDEA similarly to Eclipse[7].

 Review and align coding conventions and Checkstyle configuration.

 Compare Checkstyle configuration / coding conventions with other projects (like ldaptive).

As you can see, there’s plenty of work to do.

[Misagh has already voiced interest, and this message is in response to his reminder to me.]

Thank you for your time,
Tom 

P.S. I likely have missed some tasks, I should probably create a super-task in JIRA if there’s interest.

[1] https://wiki.shibboleth.net/confluence/display/DEV/Java+Coding+Conventions

[2] https://issues.shibboleth.net/jira/browse/IDP-865

[3] https://issues.shibboleth.net/jira/browse/JPAR-60

[4] https://issues.shibboleth.net/jira/browse/JPAR-83

[5] https://issues.shibboleth.net/jira/browse/JPAR-85

[6] https://issues.shibboleth.net/jira/browse/JPAR-77

[7] https://wiki.shibboleth.net/confluence/display/DEV/Configuring+Eclipse