EDS maxPreferredIdPs and <div> idpSelectPreferredIdPTile

[Rod Widdowson]

Looks like a bug to me.  Can you pop in a JIRA case?  Thanks

 

From: dev [mailto:dev-bounces at shibboleth.net] On Behalf Of Scott Koranda
Sent: 25 February 2016 15:26
To: Shib Dev
Subject: EDS maxPreferredIdPs and <div> idpSelectPreferredIdPTile

 

Hi,

 

My EDS 1.1.0 deployment uses the default value of maxPreferredIdPs = 3.

 

When I set preferredIdP to an array containing 3 IdP entityIDs the resulting idPSelectPreferredIdPTile <div> only contains 2 child <div>s of class IdPSelectPreferredIdPButton.

 

I expected 3.

 

I see that the getPreferredIdPs function includes this:

 

if(null != preferredIdP){
            for(i=0; i < preferredIdP.length && i < maxPreferredIdPs-1; i++){
                idps[i] = getIdPFor(preferredIdP[i]);
                offset++;
            }
        }


Is 'maxPreferredIdPs - 1 ' correct? 

 

When I remove "-1" I get the result I expect, 3 child <div>s.

 

Thanks,

 

Scott K

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/dev/attachments/20160225/f0da0b45/attachment.html>