Drop container logging in idp-tomcat|jetty-base

Cantor, Scott cantor.2 at osu.edu
Fri Aug 19 13:08:59 EDT 2016


> Reasons are, (a) I don’t have an env to test Tomcat + SLF4J performance, and
> (b) Jetty still writes to its default logger (as defined in etc/jetty-logging.xml,
> we could override) unless the location of the Logback configuration File is
> supplied when starting (-Dlogback.configurationFile=...) _and_ we resolve
> the SLF4J multiple bindings warning (e.g. by sending to /dev/null dunno).
> 
> So, pending discussion/objection, I think it’s best to only do Logback
> access/request logging for Tomcat and Jetty (that at least seems
> straightforward).

Well, it's straightforward, but the goal of the Windows install of Jetty should be to have it production-capable, and I think rolling logs for your container should be part of that, wheher they're heavily used or not.

Now, I'm not saying I know the best way to do that, or that we have to use logback, but I didn't see value in two logging implementations if we could use one, and I've used logback with Jetty for years myself.

As far as the warning, I don't think it really matters much, but it seems to be specific to Jetty because it doesn't have a classloader we can isolate from the webapp by default.

Now, what we do for our tests, obviously that doesn't matter.

And what we "distribute" outside Windows is exactly nothing. I don't care what people misuse those files to do, that's not our problem.

But whatever we think best practice is, that's what goes in the wiki, and I documented what I had used. If there's something better, that's fine with me, but I don't think not doing it is better.

-- Scott



More information about the dev mailing list