A chance to make changes to the AttributeFilter language Element names, and a request.

[Rod Widdowson]

>> Feel free to push back, but I would make a number of changes:
>> - AttributeRequesterString -> Requester
>> - AttributeRequesterRegex -> RequesterRegex
>>
> +1 for all changes discussed so far.

These seem fine to me, but I'll take more feedback.

Which, for completeness leaves us with:

AttributeValueString -> ValueString  
	// Not about this but persuadable. ValueExact?

AttributeValueRegex -> ValueRegex
	// No problems with that (depending on what we do for AttributeValueString

AttributeScopeString -> ScopeString 
	// Not sure but would buy ValueScope or ScopeExact 
	// (depending on what we do with AttributeValueString)

AttributeScopeRegex -> ScopeRegex 
	// (depends on what we do with AttributeValueString)

NumberOfAttributeValues -> NumberOfValues
	// Seems OK to me

EntityAttributeExactMatch -> ????
	// I don't think so

EntityAttributeRegexMatch -> ????
	// I don't think so

AttributeScopeMatchesShibMDScope -> ScopeMatchesShibMDScope
	// Seems OK

AttributeInMetadata-> ???
	// Persuadable, ideas?

MappedAttributeInMetadata	
	// Persuadable (maybe), ideas?

My only comment at this stage is that this becomes a relatively complex upgrade and so, depending on how easy the xslt ends up, I would probably be less forceful about deprecating the old syntax.

/R