Duplicate signing
Brent Putman
putmanb at georgetown.edu
Fri Oct 30 03:03:52 EDT 2015
On 10/30/15 12:39 AM, Cantor, Scott wrote:
> On 10/29/15, 8:39 PM, "dev on behalf of Brent Putman" <dev-bounces at shibboleth.net on behalf of putmanb at georgetown.edu> wrote:
>
>
>> Yeah, that seems off-hand like the obvious way to do it. And have a new support method on SAMLBindingSupport to eval it, to hide the details. That could then be usable via a Predicate and/or directly in the XML signing handler, depending on which approach works better.
> Ok, I already coded up most of that anyway. I'll see which layer it makes sense to add the check.
Actually, since this will be a new minor release and we can add API,
another idea might be to add a Predicate activationCondition to
AbstractMessageHandler, that is evaled in doPreInvoke(...). That
would give all the handlers similar conditional execution capability as
the actions.
It would have to be a Predicate<MessageContext>. We could have such a
predicate for this, I suppose. But for more general use in server-side
cases like the IdP where there's a PRC, we could also have an adapter
allowing use of existing Predicate<ProfileRequestContext> impls. For
the latter, we'd need to do the thing that I was 99.9% sure we need to
do anyway to fully support the SOAP client, which is to allow walking
via MessageContext#getParent() up to the owning PRC (and potentially
down to the other MessageContext). I was going to add that soon-ish,
it's a pretty trivial change.
I'll look at this more tomorrow, but at the moment this feels like the
most general and useful solution.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/dev/attachments/20151030/bd0259c4/attachment.html>
More information about the dev
mailing list