LogoutPropagationFlowDescriptor API Changes

[Cantor, Scott]

On 10/5/15, 6:30 AM, "dev on behalf of Marvin Addison" <dev-bounces at shibboleth.net on behalf of marvin.addison at gmail.com> wrote:


>
>I would like to change the setter from setActivationCondition() to setSessionType(), and then add an additional boolean property called setExpectNoResponse().

Adding anything is fine, this is a minor release. I'm not following the first half of that sentence yet, can you restate? The activation condition I'd have to probably think about the use case for, it was really just there for uniformity. I don't know that it makes a lot of sense in this scenario, but I'm not sure what you mean by changing the setter.

> The latter property is needed for the UI because in some cases the logout protocol does not cause control to be passed back to the IdP (e.g. CAS); it's blind message sending.

Right, that's an obvious thing to use the descriptor bean for.

>Obviously I need to be able to select the same descriptor in both cases, and the only meaningful input common to both cases is the SPSession. As far as design and extensibility, the class type is the only meaningful selection criteria I could imagine so
> it seems like a reasonable change in that view as well.

I get that, still trying to understand the suggested change.

-- Scott