LDAP defaults
Nate Klingenstein
ndk at internet2.edu
Thu Oct 1 17:32:18 EDT 2015
> But I suppose we could support some velocity syntax there if people thought that was valuable.
It’s not worth a huge time investment and it’s not near the top of my wishlist. It was just something that caught me off guard, and I’ll bet it’s caught others, since it’s the odd property out. It’d also be neat if the properties were both named searchFilter or userFilter if they have the same semantics, but they might not.
> The team made a decision to use startTLS by default for all LDAP integration. The support for this feature is pretty broad at this point. The ':true' spring syntax is just defaulting the value if that property isn't set.
That makes sense. Is there a reason why the defaulting here is done with Spring versus somewhere else like most of the others? Just for the composability? Are there a lot more? Is it worth making the defaulting mechanism consistent? I have no qualms with the shorthand or the convention at all, but it would be nice to ooze towards consistency with an explanation in a comment.
aithon:conf ndk$ grep -R \:true\} *
attribute-resolver-full.xml: useStartTLS="%{idp.attribute.resolver.LDAP.useStartTLS:true}">
attribute-resolver-ldap.xml: useStartTLS="%{idp.attribute.resolver.LDAP.useStartTLS:true}">
authn/ldap-authn-config.xml: p:useStartTLS="%{idp.authn.LDAP.useStartTLS:true}"
authn/ldap-authn-config.xml: p:validatePeriodically="%{idp.pool.LDAP.validatePeriodically:true}"
ldap.properties:idp.attribute.resolver.LDAP.useStartTLS = %{idp.authn.LDAP.useStartTLS:true}
Thanks all for taking the time to inform me,
Nate.
More information about the dev
mailing list