Santuario change

[Brent Putman]

On 11/5/15 12:33 PM, Brent Putman wrote:
>
> On 11/5/15 10:03 AM, Cantor, Scott wrote:
>> On 11/5/15, 2:55 AM, "dev on behalf of Brent Putman" <dev-bounces at shibboleth.net on behalf of putmanb at georgetown.edu> wrote:
>>
>>
>>
>>> As I mentioned, we already have similar issues with decryption+validation (e.g. decrypt an Assertion then validate its signature).  That is documented extensively in the Decrypter Javadocs.  This may just have to be a documentation thing.
>> It's fairly easy to trigger in a unit test. Do we want to do anything to cover this case? I guess maybe not, but it felt weird since it obviously changed behavior with 2.0.5 and our tests didn't notice. But a test here would just fail so it would be an inverse test to verify that the library contained to fail on this case I guess. Feels like we should have something.
> Yeah, I was going to look at that. I didn't now for sure whether tests
> had failed yet or not.  We should have something I guess.


For the record for the decryption+validation, we have a whole unit test
class just testing that case.

org.opensaml.xmlsec.encryption.support.DecryptionSignedContentTest


IIRC, we encountered a similar failure as here, so I added that
rootInNewDocument option and the test.

So the cloning issue is the same.  It wasn't an issue, but apparently
now it, so we'll add some tests and/or fixes to account for it.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/dev/attachments/20151105/080db361/attachment.html>