Santuario change

[Cantor, Scott]

On 11/5/15, 12:37 PM, "dev on behalf of Brent Putman" <dev-bounces at shibboleth.net on behalf of putmanb at georgetown.edu> wrote:



>No, it's awkward.  I was thinking of adding something to the clone methods to just do that.  I don't know that there's any good reason to ever return a cloned object that has a non-rooted DOM.  We could just change the no-boolean clone(XMLObject) method to do that by default.  We'd be changing behavior, but probably not in a bad way.  But if we think that's not allowed or advisable, I was thinking of adding a new CloneOutputOption enum to support representing all 3 options, and a new clone(XMLObject, CloneOutputOption).
> Then deprecate the clone(XMLObject, boolean) one.

Up to you, doesn't feel like a particularly important change to the caller, but I'm not as familiar with this code.

-- Scott