Santuario change

[Cantor, Scott]

On 11/4/15, 9:04 PM, "dev on behalf of Cantor, Scott" <dev-bounces at shibboleth.net on behalf of cantor.2 at osu.edu> wrote:



>We have a regression because of the bump of Santuario causing a failure on some encryption operations. It's possible it's my bug in the EncryptXXX actions, but Brent would have to weigh in on that.

Not sure if it's a bug, but it seems to work now if I change the NameID clone I'm doing so that it roots the clone in a new Document (adding the "true" parameter):

final NameID nameId = XMLObjectSupport.cloneXMLObject(saml2Session.getNameID(), true);
            object.setNameID(nameId);

I wasn't doing that before and it was working.


I'm not sure why assertion encryption hadn't broken. I wasn't signing them, so they really shouldn't have been marshalled yet, so shouldn't have had a parent either.

Anyway, this may be something the encrypting code needs to compensate for if we use 2.0.5. I don't know the innards in the Java well enough, but since I don't think I was violating any contract here...

I was just ignoring DOM issues and treating it as an object I could pass to an encryption method, and get back a new object. Didn't think I'd need to care about the underlying details.

-- Scott