Error Logging

[Marvin Addison]

>
> I'm not opposed to shortening stack traces but omitting the cause(s) drops
> vitally important error context in many if not most cases.
>

I took some time to review logback source and do some testing. The source
was pretty clear that the limit applies to all levels of the stack trace,
which is the behavior that Scott expected and what I want. I have tested
with an action in the IdP, and with %ex{3} I see 3 lines of stack per level:

2015-03-24 10:56:33,782 - ERROR [net.shibboleth.idp.cas:-2] - Uncaught
runtime exception
java.lang.RuntimeException: Three threw
        at
net.shibboleth.idp.cas.flow.NestedThrowAction.three(NestedThrowAction.java:30)
        at
net.shibboleth.idp.cas.flow.NestedThrowAction.two(NestedThrowAction.java:23)
        at
net.shibboleth.idp.cas.flow.NestedThrowAction.one(NestedThrowAction.java:19)
Caused by: java.lang.RuntimeException: Sub-three threw
        at
net.shibboleth.idp.cas.flow.NestedThrowAction.subThree(NestedThrowAction.java:43)
        at
net.shibboleth.idp.cas.flow.NestedThrowAction.subTwo(NestedThrowAction.java:39)
        at
net.shibboleth.idp.cas.flow.NestedThrowAction.subOne(NestedThrowAction.java:35)

I have no idea what happened in the case where I spotted this initially;
there may be a bug somewhere, but more likely it was a configuration
problem unrelated to logging config per se.

Summary: what we have works like we want.

M
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://shibboleth.net/pipermail/dev/attachments/20150324/c64fee9b/attachment.html