IdP checkstyle config

[Cantor, Scott]

On 7/8/15, 6:14 PM, "dev on behalf of Misagh Moayyed" <dev-bounces at shibboleth.net on behalf of mmoayyed at unicon.net> wrote:



>1. Is the checkstyle.xml file found on the "Java Coding Conventions" wiki
>page [1] still used by the idp? Is it enforced directly via eclipse's
>checkstyle plugin as is described on the wiki?  (I guessed the plugin
>part)

No, the file that's used is in subversion on the parent project trunk. I updated the link. The checkstyle plugin allows the ruleset to be referenced with a URL so that's what's actually in all the .checkstyle files in the projects.

>2. Assuming it is in use, does it encapsulate all style-related concerns
>that the idp follows like declaring parameters as final, javadocs, etc?

I don't think it's exhaustive and it hasn't gotten any attention for a while.

> If I write an idp extension and have it pass that ruleset, could I be sure
>that I am style-compatible with the idp guidelines?

If you use the ruleset and read the page over and look at some examples, you should be good enough. Chad wrote all that before he left and only some of it has been corrected for the passage of time.

-- Scott